Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tableau): fine-grained page size #12354

Merged
merged 18 commits into from
Jan 16, 2025
Merged

feat(tableau): fine-grained page size #12354

merged 18 commits into from
Jan 16, 2025

Conversation

sgomezvillamor
Copy link
Contributor

This is continuation of PR #12329 and adds other fine-grained page sizes

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@sgomezvillamor sgomezvillamor mentioned this pull request Jan 15, 2025
Merged
5 tasks
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 15, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...on/src/datahub/ingestion/source/tableau/tableau.py 97.67% 1 Missing ⚠️
Files with missing lines Coverage Δ
...on/src/datahub/ingestion/source/tableau/tableau.py 88.82% <97.67%> (+0.02%) ⬆️

... and 41 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0392a22...024c398. Read the comment docs.

sgomezvillamor
sgomezvillamor commented Jan 15, 2025
View reviewed changes
metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py
@@ -69,8 +69,7 @@
"projects": ["default", "Project 2", "Samples"],
"extract_project_hierarchy": False,
"page_size": 1000,
"workbook_page_size": 1000,
"embedded_datasource_field_upstream_page_size": 1000,
"workbook_page_size": None,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None fallsback to page_size
so this is effectively the same as the previous workbook_page_size: 1000

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 15, 2025
Base automatically changed from feature/cus-3546-get-connection-object-pagination-metrics to master January 16, 2025 09:14
@sgomezvillamor sgomezvillamor merged commit b7b541c into master Jan 16, 2025
177 of 179 checks passed
@sgomezvillamor sgomezvillamor deleted the feature/cus-3546-tableau-fine-grained-page-size branch January 16, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@mayurinehate mayurinehate Awaiting requested review from mayurinehate

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @hsheth2