Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super type dbt redshift #12337

Merged

Conversation

kevinkarchacryl
Copy link
Contributor

Pretty straightforward. Rather than have the redshift "super" type show up as unknown and give a warning, let's add it to the known types. Linked to issue https://linear.app/acryl-data/issue/CUS-3600/2-is-there-a-way-for-acryl-to-handle-super-type-field

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
.../src/datahub/ingestion/source/redshift/redshift.py 36.67% <ø> (ø)
...tion/src/datahub/ingestion/source/sql/sql_types.py 78.46% <ø> (+1.53%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4633fbf...a71e75b. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 14, 2025
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 14, 2025
@kevinkarchacryl kevinkarchacryl merged commit e1d57e3 into datahub-project:master Jan 14, 2025
188 of 189 checks passed
@kevinkarchacryl kevinkarchacryl deleted the super-type-dbt-redshift branch January 14, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants