Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): only upload metadata model on root repo #12324

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 10, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from noggi January 10, 2025 23:01
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jan 10, 2025
@@ -20,11 +20,9 @@ jobs:
steps:
- name: Check whether upload to datahub is enabled
id: publish
env:
ENABLE_PUBLISH: ${{ secrets.DataHubToken }}
run: |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:73: Double quote to prevent globbing and word splitting [shellcheck]

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9897804...39a2218. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 10, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 13, 2025
@hsheth2 hsheth2 merged commit e34b2e4 into master Jan 13, 2025
213 checks passed
@hsheth2 hsheth2 deleted the feature/acr-5709 branch January 13, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants