feat(sdk): support urns in other urn constructors #12311
Conversation
github-actions
bot
added
the
ingestion
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
datahub-cyborg
bot
added
the
needs-review
| def test_urns_in_init() -> None: | ||
| platform = DataPlatformUrn("abc") | ||
| assert platform.urn() == "urn:li:dataPlatform:abc" | ||
|
|
||
| dataset_urn = DatasetUrn(platform, "def", "PROD") | ||
| assert dataset_urn.urn() == "urn:li:dataset:(urn:li:dataPlatform:abc,def,PROD)" | ||
|
|
||
| schema_field = SchemaFieldUrn(dataset_urn, "foo") | ||
| assert ( | ||
| schema_field.urn() | ||
| == "urn:li:schemaField:(urn:li:dataset:(urn:li:dataPlatform:abc,def,PROD),foo)" | ||
| ) |
There was a problem hiding this comment.
Any result different than this before looks like an error. So this seems more like a bug fix than a feat PR.
There was a problem hiding this comment.
All existing functionality is kept as is
It used be the case that things like SchemaFieldUrn(dataset, field) required dataset to be a string. But now it supports DatasetUrn as well. That's why I marked it as a feat.
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
It used be the case that things like SchemaFieldUrn(dataset, field) required dataset to be a string. Now it supports
DatasetUrnas well.Checklist