build(coverage): fix carry-forward coverage #12306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
chakru-r
force-pushed
the
codecov-carry-forward
branch
from
e1fcb8e to
89d2bd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ Continue to review full report in Codecov by Sentry.
|
chakru-r
force-pushed
the
codecov-carry-forward
branch
from
89d2bd2 to
08efaa9
Compare
Code coverage carry-forward is tied to flags (used to present modules/subprojects) and code coverage for a flag can be carried forward if ci optimizations skips a module build. So created a module `flag` for each group of projects that the ci builds together. This roughly corresponds to the groups defined in ci-optimization action.
chakru-r
force-pushed
the
codecov-carry-forward
branch
from
08efaa9 to
9b567d1
Compare
datahub-cyborg
bot
added
the
needs-review
david-leifker
approved these changes
Jan 9, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
llance
pushed a commit
to llance/datahub
that referenced
this pull request
Jan 13, 2025
llance
pushed a commit
to llance/datahub
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code coverage carry-forward is tied to flags (used to represent modules/subprojects) and code coverage for a flag can be carried forward if ci optimizations skips a module build. So created a module
flagfor each group of projects that the ci builds together. This roughly corresponds to the groups defined in ci-optimization action.Checklist