Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): make folder_path_pattern usage more clear #12298

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix(doc): make folder_path_pattern usage more clear #12298

merged 2 commits into from
Jan 8, 2025

Conversation

kevinkarchacryl
Copy link
Contributor

Trying to make the folder_path_pattern option more clear. Linked to this issue

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 8, 2025
asikowitz
asikowitz approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe start with Shared/ since that seems like a common pattern. And could you mention something about how to determine this path, like go to the folder and take the path Folder1 > Folder2 > Folder3, turn it into Folder 1/Folder 2/Folder 3

@kevinkarchacryl
Copy link
Contributor Author

@asikowitz made the suggested changes

@kevinkarchacryl kevinkarchacryl merged commit ea4d40e into datahub-project:master Jan 8, 2025
80 checks passed
@kevinkarchacryl kevinkarchacryl deleted the folder-path-pattern-doc branch January 8, 2025 22:52
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@kevinkarchacryl @llance
fix(doc): make folder_path_pattern usage more clear (datahub-project#…
4956543 
…12298)
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@kevinkarchacryl @llance
fix(doc): make folder_path_pattern usage more clear (datahub-project#…
a1d46c9 
…12298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinkarchacryl @asikowitz