log(elastic/index builder): add est time remaining #12280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datahub-cyborg
bot
added
the
needs-review
pedro93
reviewed
Jan 7, 2025
| long docsIndexed = tempDocumentsCount.getSecond() - previousDocCount; | ||
|
|
||
| // Calculate indexing rate (docs per millisecond) | ||
| double indexingRate = timeElapsed > 0 ? (double) docsIndexed / timeElapsed : 0; |
There was a problem hiding this comment.
It would be useful to get this indexing rate as a metric.
There was a problem hiding this comment.
Not a blocker for this logging right? I just want to improve the log in this PR. Feel free to send another PR with adding that metric
datahub-cyborg
bot
added
pending-submitter-response
pedro93
approved these changes
Jan 8, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
pending-submitter-response
llance
pushed a commit
to llance/datahub
that referenced
this pull request
Jan 13, 2025
llance
pushed a commit
to llance/datahub
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For long indexing tasks it is quite helpful to have an estimated time in minutes to understand how long to wait. It can be calculated outside. This makes it easier to find out.
Checklist