Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entityVersioning): initial implementation #12166

Merged

Conversation

RyanHolstien
Copy link
Collaborator

The first iteration on entity versioning with support for linking & unlinking Datasets & ML Models to version sets.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien self-assigned this Dec 18, 2024
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 18, 2024
@RyanHolstien RyanHolstien force-pushed the feat/entityVersioning branch from 0d49b56 to 4601fc3 Compare January 8, 2025 22:21
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have just requested a few simple additional tests. We can do this in a followup if you think this will block Hyejin's work.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 56.17470% with 291 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../datahubproject/openapi/v3/OpenAPIV3Generator.java 39.83% 73 Missing and 1 partial ⚠️
...roject/openapi/v3/controller/EntityController.java 12.00% 43 Missing and 1 partial ⚠️
...ory/plugins/SpringStandardPluginConfiguration.java 0.00% 39 Missing ⚠️
.../com/linkedin/metadata/entity/SearchRetriever.java 0.00% 22 Missing ⚠️
...entity/versioning/EntityVersioningServiceImpl.java 87.91% 15 Missing and 7 partials ⚠️
...sioning/validation/VersionPropertiesValidator.java 66.66% 13 Missing and 8 partials ⚠️
...n/metadata/client/EntityClientAspectRetriever.java 0.00% 9 Missing ⚠️
.../metadata/search/SearchServiceSearchRetriever.java 0.00% 9 Missing ⚠️
...enapi/config/GlobalControllerExceptionHandler.java 0.00% 9 Missing ⚠️
...tch/template/common/VersionPropertiesTemplate.java 0.00% 8 Missing ⚠️
... and 10 more
Files with missing lines Coverage Δ
.../com/linkedin/metadata/aspect/AspectRetriever.java 0.00% <ø> (ø)
...in/java/com/linkedin/metadata/aspect/ReadItem.java 33.33% <ø> (ø)
...ta/aspect/patch/template/AspectTemplateEngine.java 40.00% <ø> (ø)
...src/main/java/com/linkedin/metadata/Constants.java 0.00% <ø> (ø)
.../search/transformer/SearchDocumentTransformer.java 52.04% <ø> (+2.45%) ⬆️
...va/com/linkedin/metadata/search/utils/ESUtils.java 80.29% <100.00%> (+1.25%) ⬆️
...inkedin/metadata/service/UpdateIndicesService.java 26.40% <ø> (ø)
...inkedin/metadata/authorization/PoliciesConfig.java 93.46% <100.00%> (+0.03%) ⬆️
...nkedin/metadata/aspect/CachingAspectRetriever.java 0.00% <0.00%> (ø)
...tadata/models/registry/SnapshotEntityRegistry.java 0.00% <0.00%> (ø)
... and 18 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbadf6...882abdd. Read the comment docs.

@RyanHolstien RyanHolstien force-pushed the feat/entityVersioning branch from 515ea7a to 453c4da Compare January 14, 2025 16:50
@RyanHolstien RyanHolstien merged commit 94b9da0 into datahub-project:master Jan 14, 2025
199 of 205 checks passed
@yoonhyejin yoonhyejin mentioned this pull request Jan 14, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants