Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(structuredProperties) Add new settings aspect plus graphql changes for structured props #12052

Conversation

chriscollins3456
Copy link
Collaborator

This PR brings out the new structuredPropertySettings aspect that will allow us to set specific display preferences on structured properties for showing them on assets in the UI. This also updates all of the graphql resolvers for this new settings aspect as well as the graphql schema. Additionally, tests have been added to reflect all of these changes in the resolvers and utils classes.

There are some other miscellaneous improvements to structured properties as well such as:

  • add validation in our graphql resolver that the ID and the qualified name are the same (needed based on assumptions we make in our ES mapping code)
  • adds backend support for returning an associated urn with a structured property which will enable us to handle siblings much better in the UI.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 6, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 6, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 10, 2024
@chriscollins3456 chriscollins3456 merged commit f1ef4f8 into datahub-project:master Dec 11, 2024
109 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants