Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/tableau): apply page_size regardless of object count #12026

Merged
merged 12 commits into from
Dec 12, 2024
Merged

fix(ingest/tableau): apply page_size regardless of object count #12026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a9c10ac
remove limit of 100 for pagesize
sid-acryl Dec 4, 2024
e8baf5a
Merge branch 'master' into cus3379-tableau-ingestion-node-limit-exceeded
sid-acryl Dec 4, 2024
322430c
remove commented line
sid-acryl Dec 4, 2024
a206644
Merge branch 'cus3379-tableau-ingestion-node-limit-exceeded' of https…
sid-acryl Dec 4, 2024
5653fef
address review comments
sid-acryl Dec 5, 2024
4a12262
Merge branch 'master' into cus3379-tableau-ingestion-node-limit-exceeded
sid-acryl Dec 5, 2024
bb01bc3
Merge branch 'master' into cus3379-tableau-ingestion-node-limit-exceeded
sid-acryl Dec 6, 2024
53a205c
Merge branch 'master' into cus3379-tableau-ingestion-node-limit-exceeded
sid-acryl Dec 9, 2024
6069326
Merge branch 'master' into cus3379-tableau-ingestion-node-limit-exceeded
sid-acryl Dec 10, 2024
3fdd371
Merge branch 'master' into cus3379-tableau-ingestion-node-limit-exceeded
sid-acryl Dec 11, 2024
8462666
Merge branch 'master' into cus3379-tableau-ingestion-node-limit-exceeded
sid-acryl Dec 11, 2024
459a72d
Merge branch 'master' into cus3379-tableau-ingestion-node-limit-exceeded
sid-acryl Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/tableau/tableau_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,6 @@ def get_filter_pages(query_filter: dict, page_size: int) -> List[dict]:
len(query_filter.keys()) == 1
and query_filter.get(c.ID_WITH_IN)
and isinstance(query_filter[c.ID_WITH_IN], list)
and len(query_filter[c.ID_WITH_IN]) > 100 * page_size
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have a sense for why this code was added in the first place? should it be outright removed, or simply tweaked

I don't like removing code unless I understand why it was added in the first place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, @treff7es / @mayurinehate might be aware.

Copy link
Collaborator

@mayurinehate mayurinehate Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced here . Added PR description to help understand why .

I see some of the original logic changed in this which may have caused page_size to break.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this change is safe to get in. It would have no adverse effects.

):
ids = query_filter[c.ID_WITH_IN]
filter_pages = [
Expand Down
4 changes: 2 additions & 2 deletions metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"site": "acryl",
"projects": ["default", "Project 2", "Samples"],
"extract_project_hierarchy": False,
"page_size": 10,
"page_size": 1000,
"ingest_tags": True,
"ingest_owner": True,
"ingest_tables_external": True,
Expand Down Expand Up @@ -673,7 +673,7 @@ def test_tableau_ingest_with_platform_instance(
"site": "acryl",
"platform_instance": "acryl_site1",
"projects": ["default", "Project 2"],
"page_size": 10,
"page_size": 1000,
"ingest_tags": True,
"ingest_owner": True,
"ingest_tables_external": True,
Expand Down
Loading