-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schematron): add java capabilities for schema translation #11963
Merged
david-leifker
merged 2 commits into
datahub-project:master
from
shirshanka:feat-schematron
Nov 26, 2024
Merged
feat(schematron): add java capabilities for schema translation #11963
david-leifker
merged 2 commits into
datahub-project:master
from
shirshanka:feat-schematron
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
PR or Issue related to the ingestion of metadata
label
Nov 26, 2024
datahub-cyborg
bot
added
the
needs-review
Label for PRs that need review from a maintainer.
label
Nov 26, 2024
re-running the test 1 time |
david-leifker
approved these changes
Nov 26, 2024
jjoyce0510
reviewed
Nov 26, 2024
implementation project(':entity-registry') | ||
// | ||
// // Jackson dependencies - use the same versions as in the parent project | ||
// implementation 'com.fasterxml.jackson.core:jackson-core:2.12.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we clean these guys up?
jjoyce0510
reviewed
Nov 26, 2024
import com.linkedin.schema.SchemaMetadata; | ||
|
||
/** Base interface for converting between different schema formats. */ | ||
public interface SchemaConverter<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ingestion
PR or Issue related to the ingestion of metadata
needs-review
Label for PRs that need review from a maintainer.
release-0.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Introduces SchemaTron, an incubating toolkit for translating between different schema formats and DataHub's native schema representation. This PR focuses on Avro schema support with a CLI and a lib module.
Takes a first shot at addressing issue #11947
Key Features
Testing
Next Steps
The implementation follows DataHub conventions and is marked as incubating to gather community feedback before finalizing the APIs.
Checklist