Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdl): Add Dataplatform Instance urn pdl file #11754

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

rharisi
Copy link
Contributor

@rharisi rharisi commented Oct 30, 2024

  • These are missing files, which help in fetching platform or instance from dataPlatformInstance urn, if not present we have to fetch them by calling entity which can be avoided

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@rharisi rharisi changed the title Dataplatform Instance urn pdl file fix(pdl): Add Dataplatform Instance urn pdl file Oct 30, 2024
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on CI. I see no issues with this one!

@rharisi
Copy link
Contributor Author

rharisi commented Dec 9, 2024

Just waiting on CI. I see no issues with this one!

Fixed spotless issue

@jjoyce0510 jjoyce0510 merged commit 3084147 into datahub-project:master Jan 17, 2025
55 of 57 checks passed
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2012 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45450f1...4818f71. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants