Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): misc fixes #11678

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(misc): misc fixes #11678

merged 1 commit into from
Oct 22, 2024

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Oct 21, 2024

IgnoreUnknownMutator

Allows ignoring unknown fields to allow newer clients to execute against older servers. This is disabled by default for now, however will be enabled in the future for better client/server compatibility.

  • Enable in docker profile for smoke-tests
  • Added smoke-test using rest.li
  • Bug fix & unit test for JavaEntityClient ingestProposal when used in combination with this feature
  • Bug fix patch support using rest.li

BaseQueryFilterRewriter.java

  • Bug fix & unit test to make sure the minimum should match is preserved

View Restriction - STARTS_WITH Resource Policy

  • Added unit test for policies which include a STARTS_WITH resource match

Search Cache Configuration

  • Both caching implementations (caffeine/hazelcast) were using expireAfterAccess instead of the expected expireAfterWrite

Cypress Development

  • Update cypress-dev.sh to support authentication by default

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker david-leifker marked this pull request as draft October 21, 2024 03:15
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Oct 21, 2024
Copy link

Hello @david-leifker 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, minor clarification comment.

@@ -1173,15 +1173,15 @@ public IngestResult ingestProposal(
* @return an {@link IngestResult} containing the results
*/
@Override
public Set<IngestResult> ingestProposal(
public List<IngestResult> ingestProposal(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the IngestResult seems likely that distinctness never mattered, but could add a .distinct() if we want to retain the contract. I think it's fine without

@david-leifker david-leifker merged commit 6c55511 into master Oct 22, 2024
45 checks passed
@david-leifker david-leifker deleted the oss-fixes-20241021 branch October 22, 2024 11:59
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants