-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(misc): misc fixes #11678
fix(misc): misc fixes #11678
Conversation
Hello @david-leifker 😄 Thank you so much for opening a pull request!
|
ae6bc93
to
ad6014b
Compare
ad6014b
to
f8f924f
Compare
metadata-io/src/main/java/com/linkedin/metadata/client/JavaEntityClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking, minor clarification comment.
f8f924f
to
9b60a44
Compare
metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java
Show resolved
Hide resolved
@@ -1173,15 +1173,15 @@ public IngestResult ingestProposal( | |||
* @return an {@link IngestResult} containing the results | |||
*/ | |||
@Override | |||
public Set<IngestResult> ingestProposal( | |||
public List<IngestResult> ingestProposal( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the IngestResult seems likely that distinctness never mattered, but could add a .distinct() if we want to retain the contract. I think it's fine without
9b60a44
to
5fce564
Compare
5fce564
to
8cc9f2f
Compare
IgnoreUnknownMutator
Allows ignoring unknown fields to allow newer clients to execute against older servers. This is disabled by default for now, however will be enabled in the future for better client/server compatibility.
BaseQueryFilterRewriter.java
View Restriction -
STARTS_WITH
Resource PolicySearch Cache Configuration
expireAfterAccess
instead of the expectedexpireAfterWrite
Cypress Development
cypress-dev.sh
to support authentication by defaultChecklist