Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/looker): include project name in model/explore properties #11664

Merged
merged 4 commits into from
Oct 18, 2024
Merged

feat(ingest/looker): include project name in model/explore properties #11664

merged 4 commits into from
Oct 18, 2024
+135 −66

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 17, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 17, 2024
@github-actions GitHub Actions
Copy link

Hello @hsheth2 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

mayurinehate
mayurinehate approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 18, 2024
@hsheth2 hsheth2 merged commit dfd7293 into master Oct 18, 2024
68 of 100 checks passed
@hsheth2 hsheth2 deleted the looker-explore-properties branch October 18, 2024 20:05
aviv-julienjehannet pushed a commit to aviv-julienjehannet/datahub that referenced this pull request Oct 21, 2024
@hsheth2 @mayurinehate @aviv-julienjehannet
feat(ingest/looker): include project name in model/explore properties (…
f723f51 
…datahub-project#11664)

Co-authored-by: Mayuri Nehate <[email protected]>
epatotski pushed a commit to acryldata/datahub that referenced this pull request Oct 22, 2024
@hsheth2 @mayurinehate @patotskiy
feat(ingest/looker): include project name in model/explore properties (…
68fd3ad 
…datahub-project#11664)

Co-authored-by: Mayuri Nehate <[email protected]>
k-bartlett pushed a commit to k-bartlett/datahub that referenced this pull request Oct 23, 2024
@hsheth2 @mayurinehate @keith-fullsight
feat(ingest/looker): include project name in model/explore properties (…
c4a8001 
…datahub-project#11664)

Co-authored-by: Mayuri Nehate <[email protected]>
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@hsheth2 @mayurinehate @sleeperdeep
feat(ingest/looker): include project name in model/explore properties (…
370cd32 
…datahub-project#11664)

Co-authored-by: Mayuri Nehate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @mayurinehate