Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update title of homepage (bug) #11604

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: update title of homepage (bug) #11604

wants to merge 2 commits into from

Conversation

danielomiya
Copy link

@danielomiya danielomiya commented Oct 11, 2024 •
edited
Loading

Currently, there is a bug when you navigate to a entity's page and then go back to the home page, because the <title /> isn't updated accordingly. This PR should fix it.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 11, 2024
@danielomiya danielomiya marked this pull request as ready for review October 11, 2024 19:38
@danielomiya danielomiya changed the title fix: add title to homepage fix: update title of homepage (bug) Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielomiya