Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): Suppress ts errors on Editor.tsx #11275

Merged
merged 13 commits into from
Nov 21, 2024
Merged

fix(ts): Suppress ts errors on Editor.tsx #11275

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d0606b7
Update Editor.tsx
pinakipb2 Aug 30, 2024
77ca4ad
Merge branch 'master' into patch-1
pinakipb2 Sep 19, 2024
d7504da
Merge branch 'master' into patch-1
pinakipb2 Sep 30, 2024
9342689
Merge branch 'master' into patch-1
pinakipb2 Oct 1, 2024
d852784
Merge branch 'master' into patch-1
pinakipb2 Oct 3, 2024
e9d713f
Merge branch 'master' into patch-1
pinakipb2 Oct 6, 2024
6b46a22
Merge branch 'master' into patch-1
pinakipb2 Oct 8, 2024
1e07a94
Merge branch 'master' into patch-1
pinakipb2 Oct 12, 2024
23ffd28
Merge branch 'master' into patch-1
pinakipb2 Oct 16, 2024
3c06d26
Merge branch 'master' into patch-1
pinakipb2 Oct 31, 2024
fedc277
Merge branch 'master' into patch-1
pinakipb2 Nov 2, 2024
622e5e6
Merge branch 'master' into patch-1
pinakipb2 Nov 9, 2024
46787bd
Merge branch 'master' into patch-1
pinakipb2 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions datahub-web-react/src/app/entity/shared/tabs/Documentation/components/editor/Editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,26 +50,26 @@ export const Editor = forwardRef((props: EditorProps, ref) => {
const { manager, state, getContext } = useRemirror({
extensions: () => [
new BlockquoteExtension(),
new BoldExtension(),
new BulletListExtension(),
new BoldExtension({}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even in the Remirror docs, they are not using an empty in constructor for these extensions: https://remirror.io/docs/extensions/bold-extension

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the link of an online editor, using the same version of packages. Showing the error:

https://stackblitz.com/edit/vitejs-vite-z3rg1l?file=src%2FEditor.tsx
(You need to wait till yarn install is complete, then the tsx error will start showing)

image

new BulletListExtension({}),
new CodeBlockExtension({ syntaxTheme: 'base16_ateliersulphurpool_light' }),
new CodeExtension(),
new DataHubMentionsExtension(),
new DropCursorExtension(),
new DataHubMentionsExtension({}),
new DropCursorExtension({}),
new HardBreakExtension(),
new HeadingExtension(),
new HistoryExtension(),
new HorizontalRuleExtension(),
new HeadingExtension({}),
new HistoryExtension({}),
new HorizontalRuleExtension({}),
new ImageExtension({ enableResizing: !readOnly }),
new ItalicExtension(),
new LinkExtension({ autoLink: true, defaultTarget: '_blank' }),
new ListItemExtension(),
new ListItemExtension({}),
new MarkdownExtension({ htmlSanitizer: DOMPurify.sanitize, htmlToMarkdown, markdownToHtml }),
new OrderedListExtension(),
new UnderlineExtension(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not do this for all of these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors did not come for others.

new StrikeExtension(),
new TableExtension({ resizable: false }),
...(readOnly ? [] : [new HistoryExtension()]),
...(readOnly ? [] : [new HistoryExtension({})]),
],
content,
stringHandler: 'markdown',
Expand Down
Loading