fix(ingest): add opt/oracle in datahub-ingestion image #11099
Conversation
WalkthroughThe recent changes improve the Dockerfiles for the datahub-ingestion project by updating the Oracle Instant Client library versions, enhancing the build arguments, and ensuring essential files are included in the final image. These updates focus on using the latest software versions and optimizing the build process, ultimately leading to a more efficient and robust Docker container. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- docker/datahub-ingestion-base/Dockerfile (1 hunks)
- docker/datahub-ingestion/Dockerfile (2 hunks)
Additional comments not posted (8)
docker/datahub-ingestion/Dockerfile (2)
4-4: LGTM! Verify the impact of the updated Docker version.The change to use
head-fullinstead ofheadfor theDOCKER_VERSIONargument is approved.Ensure that the new version does not introduce any unexpected changes or dependencies.
51-51: LGTM! Verify the presence of Oracle files.The addition of the line to copy Oracle files from the
full-install-buildstage is approved.Ensure that the Oracle files are correctly included in the final image.
docker/datahub-ingestion-base/Dockerfile (6)
88-88: LGTM! Verify the updated URL for the Oracle Instant Client library (x86_64).The update to use version 21.15.0 for the Oracle Instant Client library (x86_64) is approved.
Ensure that the URL is correct and accessible.
Verification successful
Verified: The updated URL for the Oracle Instant Client library (x86_64) is correct and accessible.
The URL
https://download.oracle.com/otn_software/linux/instantclient/2115000/instantclient-basic-linux.x64-21.15.0.0.0dbru.zipreturned an HTTP 200 OK status, confirming its accessibility and correctness.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated URL for the Oracle Instant Client library (x86_64). # Test: Check if the URL is accessible. curl -I https://download.oracle.com/otn_software/linux/instantclient/2115000/instantclient-basic-linux.x64-21.15.0.0.0dbru.zipLength of output: 814
96-96: LGTM! Verify the updated URL for the Oracle Instant Client library (arm64).The update to use version 19.23.0 for the Oracle Instant Client library (arm64) is approved.
Ensure that the URL is correct and accessible.
Verification successful
The URL for the Oracle Instant Client library (arm64) version 19.23.0 is correct and accessible.
- The
curl -Icommand returned an HTTP 200 OK status, confirming that the file is available for download.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated URL for the Oracle Instant Client library (arm64). # Test: Check if the URL is accessible. curl -I https://download.oracle.com/otn_software/linux/instantclient/1923000/instantclient-basic-linux.arm64-19.23.0.0.0dbru.zipLength of output: 736
89-89: LGTM! Verify the unzip command for the Oracle Instant Client library (x86_64).The update to the unzip command to reflect version 21.15.0 for the Oracle Instant Client library (x86_64) is approved.
Ensure that the unzip command works correctly.
Verification successful
The unzip command for the Oracle Instant Client library (x86_64) is correctly used.
The
instantclient-basic-linux.x64-21.15.0.0.0dbru.zipfile is referenced in the Dockerfile for downloading, unzipping, and removing the file, confirming its correct usage.
docker/datahub-ingestion-base/DockerfileScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the unzip command for the Oracle Instant Client library (x86_64). # Test: Check if the unzip command works correctly. unzip -t instantclient-basic-linux.x64-21.15.0.0.0dbru.zipLength of output: 133
Script:
#!/bin/bash # Description: Verify the presence and usage of the Oracle Instant Client library zip file in the Dockerfile. # Search for references to the zip file in the Dockerfile and other relevant files. rg "instantclient-basic-linux.x64-21.15.0.0.0dbru.zip" -A 5Length of output: 841
91-91: LGTM! Verify the library path configuration for the Oracle Instant Client library (x86_64).The update to the library path configuration to reflect version 21.15 for the Oracle Instant Client library (x86_64) is approved.
Ensure that the library path configuration works correctly.
90-90: LGTM! Verify the removal command for the Oracle Instant Client library zip file (x86_64).The update to the removal command to reflect version 21.15.0 for the Oracle Instant Client library zip file (x86_64) is approved.
Ensure that the removal command works correctly.
97-97: LGTM! Verify the unzip command for the Oracle Instant Client library (arm64).The update to the unzip command to reflect version 19.23.0 for the Oracle Instant Client library (arm64) is approved.
Ensure that the unzip command works correctly.
Verification successful
The
wgetandunzipcommands for the Oracle Instant Client library (arm64) are correctly set up in the Dockerfile.The Dockerfile includes a
wgetcommand to download theinstantclient-basic-linux.arm64-19.23.0.0.0dbru.zipfile, followed by anunzipcommand to extract it. This ensures that the required file is available for extraction during the Docker build process.
wgetcommand to download the file:wget --no-verbose -c https://download.oracle.com/otn_software/linux/instantclient/1923000/instantclient-basic-linux.arm64-19.23.0.0.0dbru.zip
unzipcommand to extract the file:unzip instantclient-basic-linux.arm64-19.23.0.0.0dbru.zipScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the unzip command for the Oracle Instant Client library (arm64). # Test: Check if the unzip command works correctly. unzip -t instantclient-basic-linux.arm64-19.23.0.0.0dbru.zipLength of output: 135
Script:
#!/bin/bash # Description: Check if the Oracle Instant Client zip file exists in the repository. # Search for the zip file in the repository. fd -H 'instantclient-basic-linux.arm64-19.23.0.0.0dbru.zip'Length of output: 59
Script:
#!/bin/bash # Description: Check the Dockerfile for commands related to downloading the Oracle Instant Client zip file. # Search the Dockerfile for any wget or curl commands related to the zip file. rg 'wget|curl' docker/datahub-ingestion-base/Dockerfile -A 3Length of output: 979
|
@david-leifker, Please check this new change! |
github-actions
bot
added
devops
|
@david-leifker, I checked today that PR 11163 has resolved this issue. |
Checklist
Summary by CodeRabbit
New Features
Enhancements