Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setup): fix postgres setup to create temp table with no data #10154

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix(setup): fix postgres setup to create temp table with no data #10154

merged 1 commit into from
Mar 28, 2024

Conversation

trialiya
Copy link
Contributor

@trialiya trialiya commented Mar 27, 2024 •
edited
Loading

WITH [ NO ] DATA
This clause specifies whether or not the data produced by the query should be copied into the new table. If not, only the table structure is copied. The default is to copy the data.

The default behavior is bad because it copies all data which causes unnecessary load, especially if the table is large.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 27, 2024
@trialiya trialiya force-pushed the fix-postgres-setup-init-sql branch from ccd88e2 to 30a67cf Compare March 28, 2024 07:48
@myuk myuk assigned myuk and david-leifker and unassigned myuk Mar 28, 2024
@david-leifker david-leifker merged commit 140c0f1 into datahub-project:master Mar 28, 2024
38 checks passed
@trialiya trialiya deleted the fix-postgres-setup-init-sql branch April 25, 2024 23:29
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@trialiya @sleeperdeep
fix(setup): fix postgres setup to create temp table with no data (dat…
fc71623 
…ahub-project#10154)

Co-authored-by: Хазиев Ленар <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees

@david-leifker david-leifker

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trialiya @david-leifker @myuk