Skip to content

Commit

Permalink
fix: minor change
Browse files Browse the repository at this point in the history
  • Loading branch information
sagar-salvi-apptware committed Jan 8, 2025
1 parent 36f746f commit 4a9ec88
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 218 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ def replace_parameters(match):
if key in self.source_config.lookml_parameter:
return str(self.source_config.lookml_parameter.get(key))

# Log warning for missing parameter
logger.warning(f"Parameter '@{{{key}}}' not found in configuration.")
return ""

Check warning on line 366 in metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py

View check run for this annotation

Codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py#L365-L366

Added lines #L365 - L366 were not covered by tests

Expand All @@ -372,7 +371,6 @@ def replace_liquid_variables(match):
if key in self.source_config.liquid_variable:
return str(self.source_config.liquid_variable.get(key))

# Log warning for missing liquid variable
logger.warning(f"Liquid variable '${{{key}}}' not found in configuration.")
return ""

Check warning on line 375 in metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py

View check run for this annotation

Codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py#L374-L375

Added lines #L374 - L375 were not covered by tests

Expand Down Expand Up @@ -455,7 +453,7 @@ def process_lookml_template_language(
), # Now resolve liquid variables
LookmlParameterTransformer(
source_config=source_config
), # Remove @{variable} with its corresponding value
), # Remove @{param}/${var} with its corresponding value
DropDerivedViewPatternTransformer(
source_config=source_config
), # Remove any ${} symbol
Expand Down
215 changes: 0 additions & 215 deletions metadata-ingestion/src/datahub/ingestion/source/looker/looker_test.py

This file was deleted.

0 comments on commit 4a9ec88

Please sign in to comment.