Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: update example/raft-kv-rocksstore to use storage-v2 API #979

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Refactor: update example/raft-kv-rocksstore to use storage-v2 API #979

merged 1 commit into from
Dec 21, 2023
+271 −381

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Dec 21, 2023 •
edited
Loading

Changelog

Refactor: update example/raft-kv-rocksstore to use storage-v2 API

This change is Reviewable

drmingdrmer
drmingdrmer commented Dec 21, 2023
View reviewed changes
Copy link
Member Author

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ariesdevil and @lichuang)

@drmingdrmer drmingdrmer merged commit 87e5bd5 into databendlabs:main Dec 21, 2023
24 of 25 checks passed
@drmingdrmer drmingdrmer deleted the 33-rocks-v2 branch December 21, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichuang lichuang Awaiting requested review from lichuang

@ariesdevil ariesdevil Awaiting requested review from ariesdevil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update example raft-kv-rocksstore to use storage-v2
1 participant
@drmingdrmer