Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add default for unwrap #1294

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Chore: add default for unwrap #1294

merged 2 commits into from
Jan 9, 2025

Conversation

vigith
Copy link
Contributor

@vigith vigith commented Jan 8, 2025

If we do not add a default, I am getting a runtime panic because leader-id could be None?

thread 'main' panicked at src/pb_impl/impl_vote.rs:30:37:
called `Option::unwrap()` on a `None` value
stack backtrace:

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I missed this default value handling!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vigith)

@drmingdrmer drmingdrmer merged commit 52629cb into databendlabs:main Jan 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants