Change: Membership::new_with_defaults() #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new method `Membership::new_with_defaults()` that creates `Membership` using `C::Node::default()` to build nodes. And the existing method `Membership::new()` does not require `C::Node: Default` any more. The corresponding change includes it `Membership::new()` now returns a `NodeNotFound` error if the the given nodes do not include all of the given Voter ids. Other changes: - Add error `MembershipError` to represent errors occuring during building a `Membership`. - Remove `IntoNodes` implementations for `BTreeSet`. Add `IntoNodes` for `HashMap<NID, N>`. Upgrade tip: - Calls to `Membership::new()` should provide all nodes(Voters and Learners), and deal with the returned `Result`. - Switch to using `Membership::new_with_defaults()` when needed if `C::Node` implements `Default`
drmingdrmer
force-pushed
the
173-membership
branch
from
cda101b to
5354002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Change: Membership::new_with_defaults()
Add new method
Membership::new_with_defaults()that createsMembershipusingC::Node::default()to build nodes. And the existingmethod
Membership::new()does not requireC::Node: Defaultany more.The corresponding change includes it
Membership::new()now returns aNodeNotFounderror if the the given nodes do not include all of thegiven Voter ids.
Other changes:
Add error
MembershipErrorto represent errors occuring duringbuilding a
Membership.Remove
IntoNodesimplementations forBTreeSet. AddIntoNodesforHashMap<NID, N>.Upgrade tip:
Calls to
Membership::new()should provide all nodes(Voters andLearners), and deal with the returned
Result.Switch to using
Membership::new_with_defaults()when needed ifC::NodeimplementsDefaultThis change is