-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: expose AsyncRuntime Oneshot via trait #1200
Refactor: expose AsyncRuntime Oneshot via trait #1200
Conversation
Do I need to include a changelog entry in the PR description? Something like ChangelogChange: Interfaces of the oneshot channel in |
Use a commit message starts with The PR title is not used when building change log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice shot. Thank you!
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SteveLauC)
This is a breaking change for users who implement their own |
The change log is built with this script: After that, the generated change-log still needs a few manually update. |
Get it, thanks for showing me this! |
I forgot the commit message needs to be updated when merging. I've force-pushed the main branch to correct the commit message... |
Thanks for fixing that for me! 😄 |
What does this PR do
Exposes
Oneshot
viatrait Oneshot
.Closes #1198
Checklist
This change is