CARDS-2609: Configurable actions on user dashboard and related views #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for UI extensions to configure what actions should be allowed
- Adds support for disableDeletion, disableMoving and disableCreation to
form and subject clinician UIs where applicable
- Adds support for disableActions and disableExpansion to subject and form
dashboard views
- Add support for seperate admin extensions for the clinician UIs
- This allows seperate action configurations for admin and non-admin views
Within built in CARDS runmodes, these configurations are unused.
This means that no UI changes should be detected when running CARDS in any built in runmode.
Fix disableCreation configuration not being passed through properly
Add minimum height for live table data rows - Improves appearance for rows with no avatars or icon buttons
marta-
reviewed
Dec 4, 2024
| @@ -65,6 +65,9 @@ const liveTableStyle = theme => ({ | |||
| float : "right" | |||
| } | |||
| }, | |||
| dataRow: { | |||
| height: "3em" | |||
There was a problem hiding this comment.
wouldn't min-height be better in case the content requires 2 lines?
There was a problem hiding this comment.
min-height doesn't work on table rows which is what this is applied to. height acts like min-height with the table row expanding vertically if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within built in CARDS runmodes, these configurations are unused. This means that no UI changes should be detected when running CARDS in any built in runmode.
To Test:
As these configurations are unused, all UIs within this branch should remain untouched. Instructions on what should be tested to ensure this can be found in the related SPARC pull request. That PR also contains instructions and configurations for testing when functionality has been changed.