Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HERACLES-31: Auto create visit numbers for heracles forms #1818

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

acrowthe
Copy link
Contributor

@acrowthe acrowthe commented Oct 3, 2024

  • Adds VisitNumberConfiguration and VisitNumberEditor
  • Editor runs on all new forms that have a matching configuration
  • Pulls the study stream from a study stream form based on a reference
    question in the form being process
  • Saves the lowest valid and unused visit number into the visit number answer
    for the correct study stream form
    • If the visit nunber is inside a conditional section the answer will last until the
      form is saved by the front end. This means the user can satisfy the condition and
      see the generated visit number on the first edit but it will be discard if they do
      not satisfy the condition and then close the edit page
      eg. by picking Triggered Assessment instead of Visit or by closing the form without
      picking either

Base automatically changed from misc-version-mismatch to dev October 4, 2024 15:08
- Adds VisitNumberConfiguration and VisitNumberEditor
- Editor runs on all new forms that have a matching configuration
- Pulls the study stream from a study stream form based on a reference
  question in the form being process
- Saves the lowest valid and unused visit number into the visit number answer
  for the correct study stream form
  - If the visit nunber is inside a conditional section the answer will last until the
    form is saved by the front end. This means the user can satisfy the condition and
    see the generated visit number on the first edit but it will be discard if they do
    not satisfy the condition and then close the edit page
    eg. by picking Triggered Assessment instead of Visit or by closing the form without
    picking either
@acrowthe acrowthe added the urgent Needs to be completed and merged asap label Oct 7, 2024
@marta- marta- requested a review from sdumitriu October 8, 2024 16:08
@Hajany Hajany requested a review from sashaandjic October 9, 2024 01:03
@sashaandjic sashaandjic added the testing... Testing in progress label Oct 9, 2024
@sashaandjic
Copy link
Contributor

sashaandjic commented Oct 10, 2024

EDITED: Works really well, still testing...

@sashaandjic sashaandjic added question Further information is requested bug Something isn't working testing... Testing in progress and removed testing... Testing in progress bug Something isn't working question Further information is requested labels Oct 10, 2024
Copy link
Contributor

@sashaandjic sashaandjic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@sashaandjic sashaandjic added tested Passed manual testing, needs code review and removed testing... Testing in progress labels Oct 15, 2024
@acrowthe acrowthe removed the urgent Needs to be completed and merged asap label Oct 23, 2024
@marta- marta- added conflict There's a merge conflict to be resolved needs rebase labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There's a merge conflict to be resolved needs rebase tested Passed manual testing, needs code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants