build(github): fix broken github actions and regenerate some code (#615)

* build(proto): regenerate .proto files, only whitespace changes

* build(github): check generated code on PRs to v0.x-dev

* chore: regenerate mocks

* chore(github): configure yamllint for github workflows code

* build(github): cleanup conditions when to run jobs

* build(github): rename linter.yml to markdown-linter.yml

* build(github): use super-linter action instead of docker image

* chore: fix linter issue

* build(github): change *.md link checker action

* doc: fix broken links in *.md files

.github/workflows/.yamllint

@@ -0,0 +1,6 @@
+extends: default
+
+rules:
+    line-length: disable
+    truthy: disable
+    comments: {min-spaces-from-content: 1}

.github/workflows/build.yml

@@ -7,9 +7,7 @@ on:
   push:
     branches:
       - master
-      - release/**
-      - v0.*-dev
-
+      - v[0-9]+.[0-9]+-dev
 jobs:
   build:
     name: Build

.github/workflows/check-generated.yml

@@ -6,8 +6,13 @@
 name: Check generated code
 on:
   pull_request:
+    paths:
+      - "**.go"
+      - "**.proto"
+  push:
     branches:
       - master
+      - v[0-9]+.[0-9]+-dev
 
 permissions:
   contents: read
@@ -18,15 +23,15 @@ jobs:
     steps:
       - uses: actions/[email protected]
         with:
-          go-version: '1.19'
+          go-version: "1.19"
 
       - uses: actions/checkout@v3
 
       - name: "Check generated mocks"
         run: |
           set -euo pipefail
 
-          readonly MOCKERY=2.12.3  # N.B. no leading "v"
+          readonly MOCKERY=2.23.1  # N.B. no leading "v"
           curl -sL "https://github.com/vektra/mockery/releases/download/v${MOCKERY}/mockery_${MOCKERY}_Linux_x86_64.tar.gz" | tar -C /usr/local/bin -xzf -
           make mockery 2>/dev/null
 
@@ -44,11 +49,11 @@ jobs:
     steps:
       - uses: actions/[email protected]
         with:
-          go-version: '1.19'
+          go-version: "1.19"
 
       - uses: actions/checkout@v3
         with:
-          fetch-depth: 1  # we need a .git directory to run git diff
+          fetch-depth: 1 # we need a .git directory to run git diff
 
       - name: "Check protobuf generated code"
         run: |

.github/workflows/e2e.yml

@@ -3,12 +3,15 @@ name: e2e
 # Runs the CI end-to-end test network on all pushes to master or release
 # branches and every pull request, but only if any Go files have been changed.
 on:
-  workflow_dispatch:  # allow running workflow manually
+  workflow_dispatch: # allow running workflow manually
   pull_request:
+    paths:
+      - "**Dockerfile"
+      - "**.go"
   push:
     branches:
       - master
-      - release/**
+      - v[0-9]+.[0-9]+-dev
 
 jobs:
   e2e-test:

.github/workflows/lint.yml

@@ -9,9 +9,13 @@ name: Golang Linter
 
 on:
   pull_request:
+    paths:
+      - "**.go"
   push:
     branches:
       - master
+      - v[0-9]+.[0-9]+-dev
+
 jobs:
   golangci:
     name: golangci-lint
@@ -26,7 +30,7 @@ jobs:
           submodules: true
       - uses: actions/[email protected]
         with:
-          go-version: '^1.19'
+          go-version: "^1.19"
       - uses: technote-space/get-diff-action@v6
         with:
           PATTERNS: |

.github/workflows/markdown-links.yml

@@ -1,11 +1,15 @@
+---
 name: Check Markdown links
 
 on:
+  # Temporarily disabled job on PRs. Re-enable when docs are fixed.
+  # pull_request:
+  #   paths:
+  #     - "**.md"
   push:
     branches:
       - master
-  pull_request:
-    branches: [master]
+      - v[0-9]+.[0-9]+-dev
 
 jobs:
   markdown-link-check:
@@ -16,8 +20,8 @@ jobs:
         with:
           PATTERNS: |
             **/**.md
-      - uses: creachadair/github-action-markdown-link-check@master
+      - uses: gaurav-nelson/github-action-markdown-link-check@v1
         with:
-          check-modified-files-only: 'yes'
-          config-file: '.md-link-check.json'
+          check-modified-files-only: "yes"
+          config-file: ".md-link-check.json"
         if: env.GIT_DIFF

.github/workflows/linter.yml → .github/workflows/markdown-linter.yml

@@ -1,17 +1,14 @@
 name: Markdown Linter
 on:
-  push:
-    branches:
-      - master
-    paths:
-      - "**.md"
-      - "**.yml"
-      - "**.yaml"
   pull_request:
-    branches: [master]
     paths:
       - "**.md"
       - "**.yml"
+      - "**.yaml"
+  push:
+    branches:
+      - master
+      - v[0-9]+.[0-9]+-dev
 
 jobs:
   build:
@@ -23,7 +20,7 @@ jobs:
       - name: Install dependencies
         run: sudo apt-get update && sudo apt-get install -y libpcap-dev
       - name: Lint Code Base
-        uses: docker://github/super-linter:v4
+        uses: github/super-linter@v4
         env:
           VALIDATE_ALL_CODEBASE: true
           DEFAULT_BRANCH: master

.github/workflows/proto-lint.yml

@@ -2,12 +2,11 @@ name: Protobuf Lint
 on:
   pull_request:
     paths:
-      - 'proto/**'
+      - "proto/**"
   push:
     branches:
       - master
-    paths:
-      - 'proto/**'
+      - v[0-9]+.[0-9]+-dev
 
 jobs:
   lint:
@@ -18,4 +17,4 @@ jobs:
       - uses: bufbuild/[email protected]
       - uses: bufbuild/buf-lint-action@v1
         with:
-          input: 'proto'
+          input: "proto"

.github/workflows/tests.yml

@@ -2,13 +2,12 @@
 name: Test
 on:
   pull_request:
-  push:
     paths:
       - "**.go"
+  push:
     branches:
       - master
-      - release/**
-      - v0.*-dev
+      - v[0-9].[0-9]+-dev
 jobs:
   tests:
     runs-on: ubuntu-latest