chore(release): update changelog and bump version to 1.8.0-rc.1 #2423
+102
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request marks the release of version 1.8.0-rc.1 for the Dashpay platform, transitioning from the development version 1.8.0-dev.2. The update introduces a significant breaking change related to distributing prefunded specialized balances after voting. Multiple packages across the platform have been updated to this new version, including Rust (Cargo) and JavaScript (package.json) based packages. The release includes several bug fixes addressing issues in document purchases, key retrieval, and consensus error deserialization. Improvements in testing coverage and various maintenance tasks are also noted. Changes
Possibly related PRs
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (20)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
CHANGELOG.md (3)
6-6: Duplicate entry for prefunded specialized balances change.The same change is listed under both "BREAKING CHANGES" and "Features" sections. Consider keeping it only in the "BREAKING CHANGES" section since breaking changes are more critical to highlight.
Also applies to: 10-10
15-18: Bug fix descriptions could be more descriptive.The bug fixes section would benefit from more detailed descriptions:
- What was the specific issue with document purchases from different epochs?
- What was the impact of retrieving multiple keys instead of one?
- What was the root cause of the consensus error deserialization failure?
Consider adding more context to help users understand the fixes better.
23-23: Test coverage improvement lacks details.The test coverage improvement entry "unify identity versioned cost coverage" would benefit from explaining:
- What aspects of identity versioned costs are now covered
- How the coverage was improved/unified
- The impact of this improvement
Consider expanding this entry to provide more context.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (45)
CHANGELOG.md(1 hunks)package.json(1 hunks)packages/bench-suite/package.json(1 hunks)packages/check-features/Cargo.toml(1 hunks)packages/dapi-grpc/Cargo.toml(1 hunks)packages/dapi-grpc/package.json(1 hunks)packages/dapi/package.json(1 hunks)packages/dash-spv/package.json(1 hunks)packages/dashmate/package.json(1 hunks)packages/dashpay-contract/Cargo.toml(1 hunks)packages/dashpay-contract/package.json(1 hunks)packages/data-contracts/Cargo.toml(1 hunks)packages/dpns-contract/Cargo.toml(1 hunks)packages/dpns-contract/package.json(1 hunks)packages/feature-flags-contract/Cargo.toml(1 hunks)packages/feature-flags-contract/package.json(1 hunks)packages/js-dapi-client/package.json(1 hunks)packages/js-dash-sdk/package.json(1 hunks)packages/js-grpc-common/package.json(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/package.json(1 hunks)packages/platform-test-suite/package.json(1 hunks)packages/rs-dapi-client/Cargo.toml(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml(1 hunks)packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml(1 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value-convertible/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)packages/rs-platform-versioning/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)packages/wallet-lib/package.json(1 hunks)packages/wallet-utils-contract/Cargo.toml(1 hunks)packages/wallet-utils-contract/package.json(1 hunks)packages/wasm-dpp/Cargo.toml(1 hunks)packages/wasm-dpp/package.json(1 hunks)packages/withdrawals-contract/Cargo.toml(1 hunks)packages/withdrawals-contract/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (44)
- packages/dashpay-contract/Cargo.toml
- packages/js-dash-sdk/package.json
- packages/rs-platform-version/Cargo.toml
- packages/feature-flags-contract/Cargo.toml
- packages/dapi-grpc/package.json
- packages/rs-platform-versioning/Cargo.toml
- packages/withdrawals-contract/package.json
- packages/rs-sdk/Cargo.toml
- packages/wallet-utils-contract/Cargo.toml
- packages/dpns-contract/package.json
- packages/withdrawals-contract/Cargo.toml
- packages/dapi/package.json
- packages/masternode-reward-shares-contract/package.json
- packages/wallet-lib/package.json
- packages/feature-flags-contract/package.json
- packages/rs-platform-value-convertible/Cargo.toml
- packages/js-dapi-client/package.json
- packages/strategy-tests/Cargo.toml
- packages/simple-signer/Cargo.toml
- packages/rs-dapi-grpc-macros/Cargo.toml
- packages/dapi-grpc/Cargo.toml
- packages/platform-test-suite/package.json
- packages/data-contracts/Cargo.toml
- packages/rs-dapi-client/Cargo.toml
- packages/rs-platform-value/Cargo.toml
- packages/wasm-dpp/package.json
- packages/dashpay-contract/package.json
- packages/wasm-dpp/Cargo.toml
- packages/rs-platform-serialization-derive/Cargo.toml
- packages/wallet-utils-contract/package.json
- packages/masternode-reward-shares-contract/Cargo.toml
- package.json
- packages/check-features/Cargo.toml
- packages/rs-json-schema-compatibility-validator/Cargo.toml
- packages/dashmate/package.json
- packages/rs-platform-serialization/Cargo.toml
- packages/bench-suite/package.json
- packages/rs-drive-proof-verifier/Cargo.toml
- packages/rs-drive/Cargo.toml
- packages/rs-drive-abci/Cargo.toml
- packages/js-grpc-common/package.json
- packages/dash-spv/package.json
- packages/rs-dpp/Cargo.toml
- packages/dpns-contract/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms (192)
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dash-spv) / Linting
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (withdrawals-contract) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dash-spv) / Linting
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (withdrawals-contract) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dash-spv) / Linting
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (withdrawals-contract) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Tests
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dash-spv) / Linting
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (withdrawals-contract) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Tests
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dash-spv) / Linting
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (withdrawals-contract) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Tests
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dash-spv) / Linting
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (withdrawals-contract) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Tests
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dash-spv) / Linting
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (withdrawals-contract) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Tests
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dash-spv) / Linting
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Tests
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: JS packages (@dashevo/grpc-common) / Tests
- GitHub Check: JS packages (@dashevo/grpc-common) / Linting
- GitHub Check: JS packages (@dashevo/dpns-contract) / Linting
- GitHub Check: JS packages (@dashevo/dash-spv) / Tests
- GitHub Check: JS packages (@dashevo/dashpay-contract) / Tests
- GitHub Check: JS packages (@dashevo/dapi-client) / Tests
- GitHub Check: JS packages (@dashevo/dapi) / Tests
- GitHub Check: Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
- GitHub Check: Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
- GitHub Check: Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
- GitHub Check: Packages functional tests / Run functional tests
- GitHub Check: JS code security audit / Run Code QL
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
1-1: Consider adding a table of contents for better navigation.For a changelog of this size, a table of contents would help users quickly find specific versions.
+ # Changelog + + ## Table of Contents + + - [v1.8.0-rc.1 (2025-01-15)](#v180-rc1-2025-01-15) + - [v1.8.0-dev.2 (2024-12-19)](#v180-dev2-2024-12-19) + - [v1.7.1 (2024-12-19)](#v171-2024-12-19) + ...
32-32: Fix typo in commit message."Masternode" should be capitalized consistently.
- * **platform:** distribute prefunded specialized balances after vote (#2422) + * **platform:** distribute prefunded specialized balances after Masternode vote (#2422)Also applies to: 33-33
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (18)
- GitHub Check: Rust packages (dpp) / Detect immutable structure changes
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Linting
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (dash-sdk) / Unused dependencies
- GitHub Check: Rust packages (dash-sdk) / Tests
- GitHub Check: Rust packages (dash-sdk) / Linting
- GitHub Check: Rust packages (dash-sdk) / Check each feature
- GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
- GitHub Check: Rust packages (dashpay-contract) / Tests
- GitHub Check: Rust packages (dashpay-contract) / Formatting
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (2)
CHANGELOG.md (2)
1-1: LGTM!The changelog follows the conventional commit format and provides a comprehensive history of changes.
1-1: Verify version comparison links are valid.Some version comparison links may be broken or point to incorrect commits. Let's verify them:
✅ Verification successful
Version comparison links are properly formatted
The comparison links follow the correct GitHub URL structure and semantic versioning pattern. The 404 errors are expected since this is a future changelog (2024-2025) and the version tags haven't been created yet.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if version comparison links are valid # Test: Extract and verify GitHub comparison URLs rg -o 'https://github\.com/dashpay/platform/compare/v[0-9]+\.[0-9]+\.[0-9]+.*\.\.\.v[0-9]+\.[0-9]+\.[0-9]+.*\)' | while read -r url; do # Remove trailing parenthesis and check URL url=${url%)} echo "Checking $url" gh api "repos/dashpay/platform/compare/$(echo "$url" | cut -d'/' -f7)" doneLength of output: 104684
Script:
#!/bin/bash # Description: Verify version tags and link formatting # 1. Extract all version tags mentioned in links # 2. Check if the tags exist in the repository # 3. Verify link formatting echo "Checking version tags and link formatting..." # Extract and check version tags echo "Version tags mentioned in comparison links:" rg -o 'compare/v[0-9]+\.[0-9]+\.[0-9]+[^\.]+\.\.\.v[0-9]+\.[0-9]+\.[0-9]+[^\)]+' # List actual tags in the repository echo -e "\nExisting version tags in repository:" git tag -l "v*" # Check link formatting echo -e "\nChecking link formatting:" rg 'https://github\.com/dashpay/platform/compare/v.*\)' -A 1Length of output: 24164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
Breaking Changes
New Features
Bug Fixes
Chores
Test Improvements