Fix compilation issues #682 hwloc 2.x and likwid #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #685 +/- ##
===========================================
Coverage 85.1% 85.1%
===========================================
Files 336 336
Lines 24959 24959
Branches 11340 11340
===========================================
Hits 21242 21242
Misses 3693 3693
Partials 24 24 |
devreal
reviewed
Jan 31, 2020
dart-impl/base/src/hwinfo.c
Outdated
| hw.max_cpu_mhz = info->clock; | ||
| } | ||
| if (hw.num_numa < 0) { | ||
| hw.num_numa = hw.num_sockets; |
There was a problem hiding this comment.
Is there a way to get hw.num_sockets from likwid? Otherwise both will be -1 if hwloc is not available
There was a problem hiding this comment.
I have checked and found how to get numa and socket numbers in likwid :) see my commit below
devreal
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes portability fixes referent to issue #682. Tested sucessful combinations are:
I think other versions should also work.