Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createIFrameElement helper #92

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Add createIFrameElement helper #92

merged 2 commits into from
Oct 31, 2023

Conversation

kenzieschmoll
Copy link
Contributor

In trying to migrate from dart:html to package:web, it was not obvious to me how to create an iFrame element. Not sure if you think this is special enough to special case with its own helper, but thought I'd push up a PR to propose.

@srujzs

Copy link

github-actions bot commented Oct 31, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:web 0.3.1-dev ready to publish v0.3.1-dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry!

Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with adding helpers for these as needed, since it's kind of a downgrade from dart:html to create elements with string values.

Eventually, we might want to have a helper for each element type and put them in a separate file, but for now, LGTM!

@kenzieschmoll kenzieschmoll requested a review from kevmoo October 31, 2023 19:54
@kenzieschmoll kenzieschmoll merged commit d939cfe into main Oct 31, 2023
8 checks passed
@kenzieschmoll kenzieschmoll deleted the kenzieschmoll-patch-1 branch October 31, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants