Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
toolchain_os
in ios toolchain definitions
I think it worked correctly before only by accident, because of the fallback to `target_os` in build config: https://github.com/dart-lang/sdk/blob/0906af6d2f6cf8ae1eff52a93adccdaf90d13443/build/config/BUILDCONFIG.gn#L48). However when buildconfig is re-evaluated with toolchain args, current_os is set to a toolchain_os at https://github.com/dart-lang/sdk/blob/0906af6d2f6cf8ae1eff52a93adccdaf90d13443/build/toolchain/mac/BUILD.gn#L260, which causes linking issues in https://dart-review.googlesource.com/c/sdk/+/392661 (https://ci.chromium.org/ui/p/dart/builders/try/vm-mac-debug-arm64-try/12692/overview). Change-Id: I9c6129ad40a7ec26fde47816810241850b6f816f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395300 Auto-Submit: Ivan Inozemtsev <[email protected]> Reviewed-by: Slava Egorov <[email protected]> Commit-Queue: Slava Egorov <[email protected]>
- Loading branch information