-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix file_names diagnostic offset (dart-lang/linter#3020)
* fix file_names diagnostic offset * test fix
- Loading branch information
Showing
7 changed files
with
49 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// Copyright (c) 2021, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
import 'package:test_reflective_loader/test_reflective_loader.dart'; | ||
|
||
import '../rule_test_support.dart'; | ||
|
||
main() { | ||
defineReflectiveSuite(() { | ||
defineReflectiveTests(FileNamesInvalidTest); | ||
defineReflectiveTests(FileNamesNonStrictTest); | ||
}); | ||
} | ||
|
||
@reflectiveTest | ||
class FileNamesInvalidTest extends LintRuleTest { | ||
@override | ||
String get lintRule => 'file_names'; | ||
|
||
@override | ||
String get testFilePath => '$testPackageLibPath/a-test.dart'; | ||
|
||
test_invalidName() async { | ||
await assertDiagnostics(r''' | ||
class A { } | ||
''', [ | ||
lint('file_names', 0, 0), | ||
]); | ||
} | ||
} | ||
|
||
@reflectiveTest | ||
class FileNamesNonStrictTest extends LintRuleTest { | ||
@override | ||
String get lintRule => 'file_names'; | ||
|
||
@override | ||
String get testFilePath => '$testPackageLibPath/non-strict.css.dart'; | ||
|
||
test_validName() async { | ||
await assertNoDiagnostics(r''' | ||
class A { } | ||
'''); | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.