quick fix for NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW

See: #55917 Change-Id: I9576105618d0201b4fdc339361b6c164870267b9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370140 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Phil Quitslund <[email protected]> Auto-Submit: Phil Quitslund <[email protected]>
dart-lang · Jun 7, 2024 · 63d6e6f · 63d6e6f
1 parent a1b42e1
commit 63d6e6f
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml b/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
@@ -3638,9 +3638,7 @@ WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR:
   notes: |-
     The fix is to add `const` before the constructor invocation.
 WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW:
-  status: needsFix
-  notes: |-
-    The fix is to replace `new` with `const`.
+  status: hasFix
 WarningCode.NON_NULLABLE_EQUALS_PARAMETER:
   status: needsFix
   notes: |-

diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
@@ -1582,6 +1582,9 @@ final _builtInNonLintProducers = <ErrorCode, List<ProducerGenerator>>{
   WarningCode.MUST_CALL_SUPER: [
     AddCallSuper.new,
   ],
+  WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW: [
+    ReplaceNewWithConst.new,
+  ],
   WarningCode.NULLABLE_TYPE_IN_CATCH_CLAUSE: [
     RemoveQuestionMark.new,
   ],

diff --git a/pkg/analysis_server/test/src/services/correction/fix/replace_new_with_const_test.dart b/pkg/analysis_server/test/src/services/correction/fix/replace_new_with_const_test.dart
@@ -103,6 +103,12 @@ class ReplaceNewWithConstTest extends FixProcessorLintTest {
   @override
   String get lintCode => LintNames.prefer_const_constructors;
 
+  @override
+  void setUp() {
+    super.setUp();
+    writeTestPackageConfig(meta: true);
+  }
+
   Future<void> test_new() async {
     await resolveTestCode('''
 class C {
@@ -137,4 +143,23 @@ void f() {
     // handled by ADD_CONST
     await assertNoFix();
   }
+
+  Future<void> test_nonConstCallToLiteralConstructorUsingNew() async {
+    await resolveTestCode('''
+import 'package:meta/meta.dart';
+class A {
+  @literal
+  const A();
+}
+var a = new A();
+''');
+    await assertHasFix('''
+import 'package:meta/meta.dart';
+class A {
+  @literal
+  const A();
+}
+var a = const A();
+''');
+  }
 }