Skip to content

Commit

Permalink
[VM/Service] Update dart:io service extension spec
Browse files Browse the repository at this point in the history
The main purpose of these changes is to make sure that the types in
package:http_profile are compatible with the interfaces in the spec.

See runtime/vm/service/service_extension.md and
pkg/vm_service/CHANGELOG.md for the full list of changes.

TEST=pkg/vm_service/test/get_http_profile_test.dart, DevTools tests

CoreLibraryReviewExempt: Only touches sdk/lib/io/network_profiling.dart
to update the version returned by the getVersion dart:io service
extension.
Change-Id: I1b9d0b7d43defbc857a2a8fde003012effd1ee15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341120
Reviewed-by: Ben Konyi <[email protected]>
  • Loading branch information
derekxu16 committed Feb 6, 2024
1 parent e8b20f6 commit 60833d9
Show file tree
Hide file tree
Showing 7 changed files with 272 additions and 205 deletions.
30 changes: 28 additions & 2 deletions pkg/vm_service/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 13.1.0-dev
## 14.0.0
- Add the following error codes to `RPCErrorKind`:
- `kVmMustBePaused`
- `kCannotAddBreakpoint`
Expand All @@ -8,6 +8,32 @@
- `kIsolateCannotReload`
- `kIsolateNoReloadChangesApplied`
- `kInvalidTimelineRequest`
- Update to version `4.0` of the Dart IO service protocol extensions by making
the following changes:
- Change the type of the `updatedSince` parameter of `getHttpProfile` from
`int?` to `DateTime?`.
- Change the type of the `timestamp` property of `HttpProfile` from `int` to
`DateTime`.
- Add `events` property to `HttpProfileRequestRef` and `HttpProfileRequest`.
- Change the type of the `startTime` property of `HttpProfileRequestRef` and
`HttpProfileRequest` from `int` to `DateTime`.
- Change the type of the `endTime` property of `HttpProfileRequestRef` and
`HttpProfileRequest` from `int?` to `DateTime?`.
- Remove the `events` and `method` properties from `HttpProfileRequestData`.
- Make the `contentLength`, `cookies`, `followRedirects`, `headers`,
`maxRedirects`, `method`, and `persistentConnection` properties of
`HttpProfileRequestData` nullable.
- Change the type of the `startTime` property of `HttpProfileResponseData`
from `int` to `DateTime?`.
- Change the type of the `endTime` property of `HttpProfileResponseData`
from `int?` to `DateTime?`.
- Make the `cookies`, `headers`, `compressionState`, `reasonPhrase`,
`isRedirect`, `persistentConnection`, `contentLength`, `statusCode`, and
`startTime` properties of `HttpProfileResponseData` nullable.
- Add `isDirect` and `port` properties to `HttpProfileProxyData`.
- Add `arguments` property to `HttpProfileRequestEvent`.
- Change the type of the `timestamp` property of `HttpProfileRequestEvent`
from `int` to `DateTime`.

## 13.0.0
- Add Dart IO extension methods:
Expand Down Expand Up @@ -98,7 +124,7 @@ instance and connect it to a web socket URI.
- Change `HttpProfileRequestRef.id` type from `int` to `String`.
- Change `SocketStatistic.id` type from `int` to `String`.
- Change `ext.dart.io.getHttpProfileRequest` `id` parameter type from `int` to `String`.
- Change `ext.dart.io.socketProfilingEnabled` parameter from 'enable' to 'enabled'.
- Change `ext.dart.io.httpEnableTimelineLogging` parameter from 'enable' to 'enabled'.

## 10.1.2
- Fix bug where code would try to call `.toJson()` on `String`s.
Expand Down
Loading

0 comments on commit 60833d9

Please sign in to comment.