-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
In most cases, the (now removed) SDK class was patched so that the constructor redirected to a platform-specific implementation of the unmodifiable view. Uses of the SDK class in the platform code could be rewritten to the more direct use of the implementation class. The big +/- file changes are from moving the implementation classes from the patch file (typed_data_patch.dart), where they are no longer needed, to the internal file (typed_data.dart). TEST=ci Bug: #53785 Change-Id: Iaa7370de25b7fc2d26b24f7733c2892868e593cb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370661 Reviewed-by: Ömer Ağacan <[email protected]> Reviewed-by: Lasse Nielsen <[email protected]> Reviewed-by: Siva Annamalai <[email protected]> Commit-Queue: Stephen Adams <[email protected]> Reviewed-by: Brian Quinlan <[email protected]>
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,16 @@ | |
|
||
[#44876]: https://github.com/dart-lang/sdk/issues/44876 | ||
|
||
#### `dart:typed_data` | ||
|
||
- **BREAKING CHANGE** [#53785][]: The unmodifiable view classes for typed data | ||
have been removed. These classes were deprecated in Dart 3.4. | ||
|
||
To create an unmodifiable view of a typed-data object, use the | ||
`asUnmodifiableView()` methods added in Dart 3.3. | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
rakudrama
Author
Member
|
||
|
||
[#53785]: https://github.com/dart-lang/sdk/issues/53785 | ||
|
||
### Tools | ||
|
||
#### Linter | ||
|
FYI: @kevmoo @mit-mit
How do we determine if an instance is unmodifiable without being able to test its hierarchy?
This can cause many issues, specially if you need to ensure that some instances is unmodifiable or not.