#2976. Add patterns tests #3031
Conversation
| main() { | ||
| String res = ""; | ||
| switch (C(1)) { | ||
| case .one!: // ignore: unnecessary_null_assert_pattern |
There was a problem hiding this comment.
That wouldn't be allowed after all.
There was a problem hiding this comment.
Yes. Deleted this test.
|
|
||
| main() { | ||
| String res = ""; | ||
| if (C(2) case > (.one as C)) { |
There was a problem hiding this comment.
I don't think .one can be resolved, because as, even as a pattern, doesn't provide a useful context type.
|
|
||
| main() { | ||
| String res = ""; | ||
| if (C(1) case .one?) { // ignore: unnecessary_null_check_pattern |
There was a problem hiding this comment.
Do we really get unnecessary_null_check_pattern when the static type has a ?? If this is true then we should probably report it as an issue on the analyzer. Warnings are not language-defined, so we may not have any good source of truth about this question, but it seems reasonable to get it clarified.
There was a problem hiding this comment.
Yes. See dart-lang/sdk#59871
|
|
||
| main() { | ||
| String res = ""; | ||
| if (C(1) case C.one!) { // ignore: unnecessary_null_assert_pattern |
There was a problem hiding this comment.
Similar issue, I'm surprised that the warning doesn't get emitted based on the static type.
There was a problem hiding this comment.
The same as the above
|
|
||
| main() { | ||
| String res = ""; | ||
| if (C(1) case (C.one)) { |
There was a problem hiding this comment.
Perhaps?:
| if (C(1) case (C.one)) { | |
| if (C(1) case (.one)) { |
Similarly for the other cases.
There was a problem hiding this comment.
Thank you! I'm writing these tests with the full syntax to make sure that everything is working, and then I remove the types at the end. Sometimes I forget to do the last step, sorry.
| /// other than for `==` and `!=`, will have the parameter type of the | ||
| /// corresponding operator of the matched value type as context type. | ||
| /// | ||
| /// @description Checks that if a static member shorthand expression occurs in a |
There was a problem hiding this comment.
| /// @description Checks that if a static member shorthand expression occurs in a | |
| /// @description Checks that if a static member shorthand expression occurs in an |
| } | ||
| Expect.equals("ET Ok", res); | ||
|
|
||
| if ((x: ET(1)) case (x: .one,)) { |
There was a problem hiding this comment.
Perhaps?:
| if ((x: ET(1)) case (x: .one,)) { | |
| if ((x: ET(1)) case (x: .one)) { |
A record containing one named field doesn't need the trailing comma. It is allowed (just checked), but I think it's OK to use the typical syntax here (where we're not testing record syntax).
| } | ||
| Expect.equals("C Ok", res); | ||
|
|
||
| if (c case Container(m: .one,)) { |
There was a problem hiding this comment.
Same thing here: I think this test can omit the trailing comma. (We should have some other test about patterns on their own, independently of static access shorthands, where it is checked that these trailing commas don't crash the parser).
There was a problem hiding this comment.
Yes. Fixed here and below.
| main() { | ||
| String res = ""; | ||
| switch (C(1)) { | ||
| case .one!: // ignore: unnecessary_null_assert_pattern |
There was a problem hiding this comment.
Yes. Deleted this test.
|
|
||
| main() { | ||
| String res = ""; | ||
| if (C(2) case > (.one as C)) { |
|
|
||
| main() { | ||
| String res = ""; | ||
| if (C(1) case .one?) { // ignore: unnecessary_null_check_pattern |
There was a problem hiding this comment.
Yes. See dart-lang/sdk#59871
|
|
||
| main() { | ||
| String res = ""; | ||
| if (C(1) case C.one!) { // ignore: unnecessary_null_assert_pattern |
There was a problem hiding this comment.
The same as the above
|
|
||
| main() { | ||
| String res = ""; | ||
| if (C(1) case (C.one)) { |
There was a problem hiding this comment.
Thank you! I'm writing these tests with the full syntax to make sure that everything is working, and then I remove the types at the end. Sometimes I forget to do the last step, sorry.
| } | ||
| Expect.equals("ET Ok", res); | ||
|
|
||
| if ((x: ET(1)) case (x: .one,)) { |
| } | ||
| Expect.equals("C Ok", res); | ||
|
|
||
| if (c case Container(m: .one,)) { |
There was a problem hiding this comment.
Yes. Fixed here and below.
No description provided.