Fix build web compilers wasm issue #3748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three issues from the dart2js+dart2wasm PR:
YamlMap
is not aMap<String, dynamic>
,.cast()
doesn't work. Tests didn't catch this because we weren't reading from yaml.WebAssembly
is defined. Tests didn't catch this because this was only exercised in the fallback path, and we were only testing on Chrome. I've fixed the loader script and added a custom browser platform that disables WebAssembly in Chrome to make sure the fallback path is working.main.dart.js*
. When using a custom build extension for dart2js, they are actually namedmain.dart2js.js*
- I've fixed that, this is tested by the deferred imports hello world test in_test
.Sorry for the mess!
Closes #3746.
Closes #3747.