Fix #797 define properties in parent class to prevent php warnings.

danmarsden · Dec 18, 2024 · 8f3a2db · 8f3a2db
1 parent 0ff2157
commit 8f3a2db
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/classes/page_with_filter_controls.php b/classes/page_with_filter_controls.php
@@ -77,6 +77,15 @@ class mod_attendance_page_with_filter_controls {
     /** @var int */
     private $sesstype;
 
+    /** @var int */
+    public $page;
+
+    /** @var int */
+    public $group;
+
+    /** @var int */
+    public $sort;
+
     /**
      * initialise stuff.
      *

diff --git a/classes/report_page_params.php b/classes/report_page_params.php
@@ -29,18 +29,13 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class mod_attendance_report_page_params extends mod_attendance_page_with_filter_controls {
-    /** @var int */
-    public $group;
-    /** @var int */
-    public $sort;
     /** @var int */
     public $showextrauserdetails;
     /** @var int */
     public $showsessiondetails;
     /** @var int */
     public $sessiondetailspos;
-    /** @var int */
-    public $page;
+
 
     /**
      * mod_attendance_report_page_params constructor.