Fix #776

danmarsden · Nov 19, 2024 · 1249aa1 · 1249aa1
1 parent cecfc26
commit 1249aa1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/classes/form/updatesession.php b/classes/form/updatesession.php
@@ -45,9 +45,8 @@ public function definition() {
         $modcontext    = $this->_customdata['modcontext'];
         $sessionid     = $this->_customdata['sessionid'];
 
-        if (!$sess = $DB->get_record('attendance_sessions', ['id' => $sessionid] )) {
-            error('No such session in this course');
-        }
+        $sess = $DB->get_record('attendance_sessions', ['id' => $sessionid], '*', MUST_EXIST);
+
         $attendancesubnet = $DB->get_field('attendance', 'subnet', ['id' => $sess->attendanceid]);
         $defopts = ['maxfiles' => EDITOR_UNLIMITED_FILES, 'noclean' => true, 'context' => $modcontext];
         $sess = file_prepare_standard_editor($sess, 'description', $defopts, $modcontext, 'mod_attendance', 'session', $sess->id);

diff --git a/lib.php b/lib.php
@@ -349,9 +349,6 @@ function attendance_grade_item_update($attendance, $grades=null) {
     if (!isset($attendance->courseid)) {
         $attendance->courseid = $attendance->course;
     }
-    if (!$DB->get_record('course', ['id' => $attendance->course])) {
-        error("Course is misconfigured");
-    }
 
     if (!empty($attendance->cmidnumber)) {
         $params = ['itemname' => $attendance->name, 'idnumber' => $attendance->cmidnumber];