-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leaderboard widget type #15
Conversation
hi @chriskinsman , check out PR #13 which I must admit I just hadn't got round to merging in, do you think you can add anything of value to that PR? Or should I just merge in #13 - the benefit of that one that I can see is that it has documentation :) Thanks for the PR! I just need to get better at accepting PRs after feedback has been addressed, just been a tad busy recently |
That one is missing the format and unit options. Let me update my PR with Thanks! On Fri, Jan 30, 2015 at 12:01 PM, Dan Jenkins [email protected]
|
Added documentation On Fri, Jan 30, 2015 at 12:01 PM, Dan Jenkins [email protected]
|
}; | ||
|
||
// Only add unit if specified | ||
if(unit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, can you put the {
on the same line as the if statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This has been released onto npm [email protected] |
No description provided.