builds: add linux-arm64 binary to the npm package #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muvaffak Onus <[email protected]>
aluedeke
reviewed
Dec 9, 2024
| @@ -143,11 +148,13 @@ jobs: | |||
| mkdir ./npm_publish/dist/go-ios-darwin-amd64_darwin_amd64 | |||
| mkdir ./npm_publish/dist/go-ios-darwin-arm64_darwin_arm64 | |||
| mkdir ./npm_publish/dist/go-ios-linux-amd64_linux_amd64 | |||
| mkdir ./npm_publish/dist/go-ios-linux-arm64_linux_arm64 | |||
| mkdir ./npm_publish/dist/go-ios-windows-amd64_windows_amd64 | |||
| cp ./mac-bin/ios ./npm_publish/dist/go-ios-darwin-amd64_darwin_amd64/ios | |||
| cp ./mac-bin/ios ./npm_publish/dist/go-ios-darwin-arm64_darwin_arm64/ios | |||
| cp ./win-bin/ios.exe ./npm_publish/dist/go-ios-windows-amd64_windows_amd64/ios.exe | |||
| cp ./bin/ios ./npm_publish/dist/go-ios-linux-amd64_linux_amd64/ios | |||
There was a problem hiding this comment.
can't we use here the platform specific ones: bin/ios-amd64 bin/ios-arm64
There was a problem hiding this comment.
Yes but I didn't want to do a big change. Using the fat binary for both platforms is the original implementation for macOS, so just followed that.
aluedeke
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly replicating what is done for macOS arm64 build; build with GOARCH flag and use
lipoto build a fat binary. Needs a run in GH actions to confirm it's all working.Fixes #318