Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for non-empty 'Error' string in 'StartSessionResponse' #515

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

buxomant
Copy link
Contributor

Issue: When sending a StartSession request, we just check if there was an error reading the response message. However, we don't check if the response object itself contains an Error field.

Fix: Start checking for the Error field, and if present return an error accordingly.

@buxomant buxomant marked this pull request as draft November 18, 2024 11:21
ios/startsession.go Outdated Show resolved Hide resolved
@buxomant buxomant marked this pull request as ready for review November 18, 2024 12:29
@dmissmann dmissmann merged commit 1fcc2a1 into danielpaulus:main Nov 18, 2024
2 checks passed
@buxomant
Copy link
Contributor Author

For context, the use case here was a device paired with a host, but pairing was broken after the device was factory reset. This was detected by idevicepair validate, but was not detected by go-ios, until this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants