Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align MaxLength of EventName and EventKey among entities. #908

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Align MaxLength of EventName and EventKey among entities. #908

wants to merge 3 commits into from

Conversation

vladimir-kovalyuk
Copy link

@vladimir-kovalyuk vladimir-kovalyuk commented Sep 4, 2021 •
edited
Loading

Made MaxLength of EventName and EventKey properties the same as in PersistedEvent.
Added EF Migration.

fixes #898

@vladimir-kovalyuk vladimir-kovalyuk mentioned this pull request Sep 4, 2021
Open
@vladimir-kovalyuk
Copy link
Author

#898

danielgerlag
danielgerlag reviewed Sep 6, 2021
View reviewed changes
Copy link
Owner

@danielgerlag danielgerlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned in your comment that you had to update to .net 5?
Which project was that?

src/providers/WorkflowCore.Persistence.EntityFramework/Models/PersistedExecutionPointer.cs
public string EventName { get; set; }

[MaxLength(100)]
[MaxLength(200)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to create a migration for Postgres too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added migration for PostgreSql

Copy link
Author

@vladimir-kovalyuk vladimir-kovalyuk Sep 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about MySql if it requires local MySql server connection in order to create a migration.

@vladimir-kovalyuk
Copy link
Author

vladimir-kovalyuk commented Sep 7, 2021 •
edited
Loading

You mentioned in your comment that you had to update to .net 5?
Which project was that?

I was unable to run dotnet ef commands.
It seems that this line
<DotNetCliToolReference Include="Microsoft.EntityFrameworkCore.Tools.DotNet" Version="1.0.0-msbuild3-final" />
is no longer working, at least in my environment.
So I had to target net5.0 in WorkflowCore.Persistence.SqlServer project temporarily to enable dotnet ef commands and rolled project changes back then.
I tried to install/update Microsoft.EntityFrameworkCore.Tools.DotNet library to 2.0.3 version and obtained another portion of issues, some of them were about test WorkflowCore.Tests.SqlServer project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgerlag danielgerlag danielgerlag left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PersistedExecutionPointer's EventName and EventKey are shorter than PersistedEvent's ones
3 participants
@vladimir-kovalyuk @danielgerlag @Uladzimir-Kavaliuk