feat(eslint-config-airlight-base): add biome config

dalisoft · Jul 7, 2024 · 0d072b8 · 0d072b8
1 parent 2c34a14
commit 0d072b8
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 6 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -11,7 +11,7 @@ export default [
     },
     rules: {
       '@typescript-eslint/no-var-requires': 'off',
-      complexity: ['error', { max: 4 }],
+      complexity: ['error', { max: 7 }],
       'max-lines-per-function': [
         'error',
 

diff --git a/packages/eslint-config-base/README.md b/packages/eslint-config-base/README.md
@@ -3,7 +3,7 @@
 ESLint configure for base focused on code quality, security and performance on top of
 [eslint-config-airbnb-typescript/base](https://github.com/iamturns/eslint-config-airbnb-typescript).
 
-Now compatible with `oxlint` configuration
+Now compatible with `oxlint` and `biome` configuration
 
 ## Installation
 
@@ -63,6 +63,21 @@ export default [
 oxlint -c ./node_modules/eslint-config-airlight-base/oxlintrc.json
 ```
 
+### biome
+
+> If you are using **eslint + biome** combo, see [here and follow guide](https://github.com/SrBrahma/eslint-config-biome)
+
+```json title="biome.json"
+{
+  "$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
+  "extends": ["eslint-config-airlight-base/biome.json"]
+}
+```
+
+```bash
+biome check . --write
+```
+
 ## Rules
 
 We customized following rules.

diff --git a/packages/eslint-config-base/biome.json b/packages/eslint-config-base/biome.json
@@ -0,0 +1,7 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
+  "linter": {
+    "enabled": true,
+    "rules": {}
+  }
+}
diff --git a/packages/eslint-config-base/eslint.config.cjs b/packages/eslint-config-base/eslint.config.cjs
@@ -0,0 +1 @@
+module.exports = require('./flat.cjs');
diff --git a/packages/eslint-config-base/flat.cjs b/packages/eslint-config-base/flat.cjs
@@ -39,7 +39,6 @@ module.exports = tseslint.config(
         ...globals.es2020
       }
     },
-    // @ts-expect-error It should be shared for consistenty
     rules: {
       ...airbnbRules,
       ...rules

diff --git a/packages/eslint-config-base/package.json b/packages/eslint-config-base/package.json
@@ -9,6 +9,7 @@
     "./flat": "./flat.cjs",
     "./legacy": "./legacy.cjs",
     "./oxlintrc.json": "./oxlintrc.json",
+    "./biome.json": "./biome.json",
     "./settings.cjs": "./settings.cjs",
     "./overrides/*": "./overrides/*"
   },
@@ -21,10 +22,11 @@
     "flat.cjs",
     "legacy.cjs",
     "settings.cjs",
-    "oxlintrc.json"
+    "oxlintrc.json",
+    "biome.json"
   ],
   "scripts": {
-    "prepublishOnly": "node scripts/*.cjs"
+    "prepublishOnly": "node scripts/*.cjs && biome migrate eslint --write --include-inspired --include-nursery"
   },
   "engines": {
     "node": ">=18.20.3"

diff --git a/packages/eslint-config-base/rules.cjs b/packages/eslint-config-base/rules.cjs
@@ -1,3 +1,5 @@
+// @ts-expect-error Cannot find namespace 'SharedConfig'
+/** @type {Partial<Record<string, SharedConfig.RuleEntry>>} */
 module.exports = {
   '@eslint-community/eslint-comments/no-unused-disable': 'error',
   '@typescript-eslint/naming-convention': [
@@ -68,7 +70,7 @@ module.exports = {
       offsetTernaryExpressions: true
     }
   ],
-  complexity: ['error', { max: 5 }],
+  complexity: ['error', { max: 7 }],
   'max-depth': ['error', { max: 3 }],
   'max-nested-callbacks': ['error', { max: 3 }],
   'max-lines-per-function': [