WorldClockTab: Add time in other cities

[mjarkk]

Description

This adds a button that pops up a window where you can select a city.
After chosing the city the city is added to the WorldClockTab and the
time in that spesific city is displayed.

the selected cities are currently saved in memory thus reloading the app
will cause the clock to forget what you've selected.
I'm not sure how app configs are handled in this OS yet so i've left this one un-implemented.

Screenshots (if appropriate):

Type of change

Please tick the relevant option by putting an X inside the bracket

• New feature (non-breaking change which adds functionality)

Checklist:

• My code follows the guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• All current GitHub actions pass
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings
• I have read the CONTRIBUTING document

[nmcain]

This is awesome, is it ready to merge?

[mjarkk]

I've worked on this feature on a macos and linux machine and there are some things i'm not sure about:

1. It adds the timezone dependency and i'm not sure if this will work everywhere.
2. Currently the added timezones are not written to disk so restarting the app will reset the list, i'm not sure if this is oke for now and if not how the app state should be saved to disk (file format, location)

[nmcain]

Ideally, i'm looking to have settings save in a standard location, I believe that [HOME]/.config/ is pretty standard and we can work from there. As for file formats, really go with whatever you are comfortable with, i'd prefer JSON but I know writing to json in dart is a bit complex.

[mjarkk]

Lets see if i can add that before merging this.

[mjarkk]

I've added support for writing the selected cities timezones to disk and reading them on app start.

[bleonard252]

[HOME]/.config/ is pretty standard

It's standard on Linux but on Android (another target platform for some of these system apps), among other platforms, it's very much not.

I'm finally about to dig into this, so let's see how far I get before I have to leave for work 😄

[mjarkk]

@bleonard252 That seems logical.

I have no problem trying to implement this myself but i will need some directions on what kind of methods of storing configs i should use.
Thus far i have only used flutter for desktop apps and webapps so android will be something new for me.

I'm just thinking out loud here but would it make sense to have a dart package from dahliaOS for app configs purely for dahliaOS apps?

[larsb24]

@bleonard252 That seems logical.

I have no problem trying to implement this myself but i will need some directions on what kind of methods of storing configs i should use. Thus far i have only used flutter for desktop apps and webapps so android will be something new for me.

I'm just thinking out loud here but would it make sense to have a dart package from dahliaOS for app configs purely for dahliaOS apps?

The package is an idea, but doesn't exist yet. For now, I'd suggest using some database option such as either SharedPreferences or Hive