Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default verification time limit #6028

Merged

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Jan 8, 2025

Fixes dafny-lang/ide-vscode#514

What was changed?

Set a default verification time limit

How has this been tested?

Added a CLI test that checks there is a default time-out

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely add a release note for this one, and let's make sure we're really clear this is to stop runaway verification jobs and NOT to bound brittleness.

@@ -51,7 +51,7 @@ public static class BoogieOptionBag {
IsHidden = true
};

public static readonly Option<uint> VerificationTimeLimit = new("--verification-time-limit",
public static readonly Option<uint> VerificationTimeLimit = new("--verification-time-limit", () => 30,
"Limit the number of seconds spent trying to verify each procedure") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Limit the number of seconds spent trying to verify each procedure") {
"Limit the number of seconds spent trying to verify each assertion batch") {

@@ -0,0 +1,7 @@
defaultTimeLimit.dfy(4,7): Error: Verification of 'Foo' timed out after 30 seconds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can add "(the limit can be increased using --verification-time-limit)" to make it easier to get unstuck if this breaks anyone?

Can it be set to 0 to disable the limit?

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) January 9, 2025 09:50
@keyboardDrummer keyboardDrummer merged commit c79cb5e into dafny-lang:master Jan 9, 2025
22 checks passed
@keyboardDrummer keyboardDrummer deleted the defaultVerificationTimeLimit branch January 10, 2025 10:18
olivier-aws pushed a commit to olivier-aws/dafny that referenced this pull request Jan 13, 2025
Fixes dafny-lang/ide-vscode#514

### What was changed?
Set a default verification time limit

### How has this been tested?
Added a CLI test that checks there is a default time-out

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification issue
2 participants