Various cleanups #111
Merged
Various cleanups #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-aws
reviewed
Nov 6, 2023
| @@ -52,6 +52,16 @@ module Independence { | |||
| lemma {:axiom} ReturnIsIndep<T>(x: T) | |||
| ensures IsIndep(Monad.Return(x)) | |||
|
|
|||
| lemma MapIsIndep<A, B(!new)>(f: Monad.Hurd<A>, g: A -> B) | |||
stefan-aws
reviewed
Nov 6, 2023
| // TODO: While(condition, body)(init) would be cleaner | ||
| opaque ghost function While<A>(condition: A -> bool, body: A -> Monad.Hurd<A>, init: A): (f: Monad.Hurd<A>) | ||
| ensures forall s: Rand.Bitstream :: !condition(init) ==> f(s) == Monad.Return(init)(s) | ||
| opaque ghost function While<A(!new)>(condition: A -> bool, body: A -> Monad.Hurd<A>): (loop: A -> Monad.Hurd<A>) |
There was a problem hiding this comment.
I can't quite see what has caused this change yet. How does it make our life easier if we use this curried version of the current While?
There was a problem hiding this comment.
I think it's easier to view a while loop as transforming a value a: A. If you look at the diff, it was used as a function (init: A) => While(condition, body, init) in many places in the file. The curried version can just be written as While(condition, body).
There was a problem hiding this comment.
But I'm not super attached to that change, so if you don't like it, I can undo it.
stefan-aws
reviewed
Nov 6, 2023
| @@ -37,7 +37,7 @@ module DiscreteLaplace.Implementation { | |||
| } | |||
| var x := u + scale.numer * v; | |||
| y := x / scale.denom; | |||
| b := BernoulliSample(Rationals.Rational(1, 2)); | |||
| b := CoinSample(); | |||
stefan-aws
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.