This repository has been archived by the owner on Nov 15, 2024. It is now read-only.
Sourcery refactored master branch #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-16
to
+20
| download_url="{}/tarball/{}".format(BASE_CVS_URL, VERSION), | ||
| download_url=f"{BASE_CVS_URL}/tarball/{VERSION}", | ||
| test_suite="tests", | ||
| tests_require=[x.strip() for x in open("requirements_test.txt").readlines()], | ||
| tests_require=[ | ||
| x.strip() for x in open("requirements_test.txt").readlines() | ||
| ], |
There was a problem hiding this comment.
Lines 16-18 refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| str_i += str(i) + " " | ||
| str_i += f"{str(i)} " |
There was a problem hiding this comment.
Function display refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| sys.stderr.write("BLOOM: HASHID: %s\n" % self.hashid.hexdigest()[0:8]) | ||
| sys.stderr.write("BLOOM: HASHID: %s\n" % self.hashid.hexdigest()[:8]) |
There was a problem hiding this comment.
Function BloomFilter.calc_hashid refactored with the following changes:
- Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
Comment on lines
+200
to
+206
| elif self.data_is_hex: | ||
| digest = int(value, 16) | ||
| else: | ||
| if self.data_is_hex: | ||
| digest = int(value, 16) | ||
| else: | ||
| try: | ||
| digest = int(value.hex(), 16) | ||
| except: | ||
| digest = int(binascii.hexlify(value), 16) | ||
| try: | ||
| digest = int(value.hex(), 16) | ||
| except: | ||
| digest = int(binascii.hexlify(value), 16) |
There was a problem hiding this comment.
Function BloomFilter._hash refactored with the following changes:
- Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
Comment on lines
-247
to
+246
| if self.fast: | ||
| self.bitset += 1 | ||
| else: | ||
| self.bitset += self.slices | ||
| self.bitset += 1 if self.fast else self.slices |
There was a problem hiding this comment.
Function BloomFilter._add refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-307
to
+314
| if not self.saving: | ||
| if filename is None and self.filename is None: | ||
| sys.stderr.write("A Filename must be provided\n") | ||
| return False | ||
| else: | ||
| self.saving = True | ||
| if filename is not None: | ||
| self.filename = filename | ||
| compress_pickle(self.filename, self) | ||
| self.saving = False | ||
| return True | ||
| if self.saving: | ||
| return | ||
| if filename is None and self.filename is None: | ||
| sys.stderr.write("A Filename must be provided\n") | ||
| return False | ||
| else: | ||
| self.saving = True | ||
| if filename is not None: | ||
| self.filename = filename | ||
| compress_pickle(self.filename, self) | ||
| self.saving = False | ||
| return True |
There was a problem hiding this comment.
Function BloomFilter.save refactored with the following changes:
- Add guard clause (
last-if-guard)
sourcery-ai
bot
force-pushed
the
sourcery/master
branch
from
f2c37be to
5200cdf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!