-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow multiple build commands #408
Conversation
3946c5b
to
3d8b2a6
Compare
@Bickio until this is merged, how are you getting around this? |
@karlhorky I created separate action steps to npm install and run both build commands, instead of using the built-in options. It works fine, but it's not particularly clean. |
Nice, what I ended up doing was creating a new npm script called
{
"scripts": {
"prepare-for-cypress-tests": "yarn copy-default-env && yarn migrate up && yarn sync-fixtures-to-db"
}
} |
This PR from 2021 is incomplete in a couple of aspects:
|
In the 2.5 years since this PR was opened, I switched all my projects to playwright. Someone else is welcome to tidy this up if they want it merged, but I don't intend to do so myself. |
Many thanks for your feedback! It's completely understandable if your situation has changed after such a lapse of time. Perhaps, as you suggest, somebody else may like to pick this up? |
Another workaround would be to use the Split install and tests method. Using the example from @karlhorky above ^^, it might look something like this: name: E2E
on: push
jobs:
test:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Install dependencies
uses: cypress-io/github-action@v6
with:
# just perform install
runTests: false
- run: yarn copy-default-env
- run: yarn migrate up
- run: yarn sync-fixtures-to-db"
- name: Run e2e tests
uses: cypress-io/github-action@v6
with:
# we have already installed all dependencies above
install: false
# Cypress tests and config file are in "e2e" folder
working-directory: e2e |
Since this PR is incomplete and therefore cannot be merged in its current state, and because you said that you won't be working on it any further, I'm going to close it. It could be re-opened if there are any volunteers to pick it up. |
This functionality was already available for the
start
option. This PR adds it for thebuild
option as well.