test: fix example-recording failure reporting status #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MikeMcC399
force-pushed
the
recording-status
branch
from
62533bd to
1c53423
Compare
MikeMcC399
force-pushed
the
recording-status
branch
from
1c53423 to
6a0b0b7
Compare
|
This PR is not logged to the Triage board |
|
Since you added me as an "outside collaborator" in this repo, my issues and PRs are not added to the Triage board anymore. Could you please review and merge this PR? The PR corrects a long-standing bug which I recently noticed. |
|
@MikeMcC399 Hmm, true. I'll have to look into that. |
jennifer-shehane
approved these changes
Nov 20, 2023
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR corrects an issue where the example-recording.yml workflow passes back a success status to GitHub in the
paralleljob whether or not the Cypress tests from the project examples/recording pass or fail.The code example in README > Outputs is also corrected.
Verification
Manually trigger a run of workflows/example-recording.yml by clicking on "Run workflow".
After the workflow run has completed, examine the logs and confirm that one of the jobs
parallel (1)orparallel (2)is marked with a red cross to indicate failure.Confirm that the step "Print Cypress Cloud URL" was executed for both
parallel (1)andparallel (2), and that it reports the correct status of either "failure" or "success". One job should succeed, the other should fail.Revert the deliberate error and push the correction as a new commit to the repo.
Run the workflow again via "Run workflow". (Don't use "Re-run jobs" as this will run against the original commit, not the corrected one.)
Confirm that all jobs pass, that the step "Print Cypress Cloud URL" was executed in the
paralleljobs and that it reports "success".