build: fix version update for yarn workspace #1069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If scripts/update-cypress-latest-other.sh is run on a cleanly cloned repository or on one where
git clean
has been run, then it fails to update Cypress in the Yarnworkspace-2
examples/start-and-yarn-workspaces/workspace-2. If it is run again, then the update works as expected.Change
Replace the use of
npm install
in scripts/update-cypress-latest-other.sh operating on examples/start-and-yarn-workspaces byyarn workspace
commands to update Cypress to the latest version.Verification
In clone of https://github.com/cypress-io/github-action
Ensure there are no errors reported.
Compare the version of Cypress installed in examples/start-and-yarn-workspaces
cd examples/start-and-yarn-workspaces yarn list --pattern cypress
with the latest version shown by